Allow advanced search to return archived questions

[smithellis]

We do a test to see if we are using simple or regular/advanced search. If we determine we are using simple search, we won't show archived questions. If we are using advanced search, we will return archived questions.

[Copilot]

Pull Request Overview

This PR updates search filtering behavior to allow advanced search to return archived questions by conditionally applying archived filters based on the search mode (simple vs. advanced).

• Added a new parameter, is_simple_search, to the get_filter methods in search and base classes.
• Updated filter logic to conditionally exclude archived questions only on simple search.
• Propagated the search mode flag down to child filters for consistent filtering behavior.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
kitsune/search/search.py	Updated get_filter signatures and filtering logic to handle archived status
kitsune/search/base.py	Updated abstract method signature and usage of get_filter with search mode

[Copilot]

There appear to be two implementations of get_filter in the same class, which could lead to confusion or unintended behavior. Consider consolidating these definitions into a single implementation.

Suggested change

	def get_filter(self, is_simple_search: bool):
	"""Placeholder for subclasses, should be implemented there."""
	raise NotImplementedError
	# Removed redundant get_filter method from SumoSearch class.

[smithellis]

• It's an abstract method in SumoSearchInterface, so all child classes (including SumoSearch) must implement it with the same signature

• Even though SumoSearch.get_filter() just raises NotImplementedError, it needs to maintain the correct signature for consistency and to ensure proper type checking